Fixing failure for support_assist_settings in info module (#135)

* Fixing failure for support_assist_settings in info module * Fixing failure for support_assist_settings in info module * Fixing failure for support_assist_settings in info module --------- Co-authored-by: Sachin Apagundi <[email protected]> Co-authored-by: Bhavneet-Sharma <[email protected]>
dell · Nov 20, 2024 · 2d269f2 · 2d269f2
1 parent d6a589a
commit 2d269f2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/plugins/modules/info.py b/plugins/modules/info.py
@@ -201,6 +201,7 @@
   'writable_snapshots', 'smb_files'.
 - The parameter I(smb_files) would return for all the clusters.
 - When I(gather_subset) is C(smb_files), it is assumed that the credentials of all node is same as the I(hostname).
+- C(support_assist_settings) is supported for One FS version 9.5.0 and above.
 '''
 
 EXAMPLES = r'''
@@ -3957,9 +3958,7 @@ def get_support_assist_settings(self):
         if self.major > 9 or (self.major == 9 and self.minor > 4):
             return SupportAssist(self.support_assist_api, self.module).get_support_assist_settings()
         else:
-            error_msg = "support_assist_settings is supported for One FS version 9.5.0 and above."
-            LOG.error(error_msg)
-            self.module.fail_json(msg=error_msg)
+            return {}
 
     def perform_module_operation(self):
         """Perform different actions on Gatherfacts based on user parameter chosen in playbook"""

diff --git a/tests/unit/plugins/modules/test_info.py b/tests/unit/plugins/modules/test_info.py
@@ -571,17 +571,6 @@ def test_get_facts_support_assist_api_exception(self, gatherfacts_module_mock, g
         assert MockGatherfactsApi.get_gather_facts_error_response(
             gather_subset) == gatherfacts_module_mock.module.fail_json.call_args[1]['msg']
 
-    @pytest.mark.parametrize("gather_subset", [
-        "support_assist_settings"
-    ]
-    )
-    def test_get_facts_supportassist_exception(self, gatherfacts_module_mock, gather_subset):
-        """Test the get_facts that uses the support assist api endpoint to get the exception"""
-        gatherfacts_module_mock.major = 8
-        gatherfacts_module_mock.minor = 4
-        gatherfacts_module_mock.get_support_assist_settings()
-        assert "support_assist_settings is supported for One FS version 9.5.0 and above" in gatherfacts_module_mock.module.fail_json.call_args[1]['msg']
-
     @pytest.mark.parametrize("input_params", [
         {"gather_subset": "alert_settings", "return_key": "alert_settings"}
     ]