Feature: Add the option to register custom mock services #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 5, 2022 14:47
… IServiceEndpointNotificationService mocks
… it's only needed in the TestCustomService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our Plugin tests we need to mock the
IServiceEndpointNotificationService, since we have dependencies on this in our Plugins. As it is now those tests fail because the service can't be resolved.Since I don't think there's a generic solution for this (different people and tests might require different behaviours from their
IServiceEndpointNotificationServiceExecute calls) this pull request adds the option to register custom mock services.This way everyone can register their own mocking services for their test cases.
Overwriting the standard services is intentionally not supported since I can't think of any use case where this could make sense.