Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update where to instruct #93

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Update where to instruct #93

merged 4 commits into from
Mar 8, 2024

Conversation

wongjingping
Copy link
Collaborator

@wongjingping wongjingping commented Mar 8, 2024

Update the questions where query_category='where' to instruct. We only add instructions for the new instruct category (35 qns).
Removed the k_shot_prompt column
Added instructions placeholder to prompts/prompt.md

This was generated with this notebook - you might find it easier to follow along the changes from there

Removed k_shot_prompt
Updated prompt.md with instructions placeholder
@rishsriv
Copy link
Member

rishsriv commented Mar 8, 2024

THANK YOU! Much, much appreciated. This would've been such a painful exercise.

Just made a quick commit to the generate_prompt function so that instructions (when available) are in the proper format we expect them to be in. Looks good otherwise (though I haven't been able to go through the instructions)

Did go through some of the queries (and updated one of them here)

Found some very minor issues that I'll fix soon before merging – like multiline instructions not being delineated properly. Like this Always filter names using exact matchesTo get publications written by authors from a given domain, you would need to join domain, domain_author, author to link the domain to the author first, and then join with write to link with the publication id.

You and @wendy-aw don't have to spend extra time on this – I can help figure out the rest. Thanks again for doing this!

@rishsriv
Copy link
Member

rishsriv commented Mar 8, 2024

Actually just two examples that need to be fixed! Will do now and merge :D

@rishsriv rishsriv merged commit 673a2d0 into main Mar 8, 2024
1 check passed
@rishsriv rishsriv deleted the jp/instruct branch March 8, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants