Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to report results to a URL, and sample server code for saving it to a database #79

Merged
merged 15 commits into from
Feb 5, 2024

Conversation

rishsriv
Copy link
Member

@rishsriv rishsriv commented Feb 4, 2024

No description provided.

@wongjingping
Copy link
Collaborator

Made a few key changes:

  • Separated cloud function for writing to Bigquery / Postgres into different folders. Users can distinguish which cloud function they want to deploy more easily with worrying about bringing in excessive deps. This also facilitates easy switching between reporting endpoints if necessary.
  • Pass all args into upload_results, and let the endpoint decide which ones it wants to keep. By passing a superset we allow users to pick and choose which metrics are meaningful to them.
  • Added instructions for deploying and testing the cloud function. A little bit more work is required for Bigquery due to the service account credentials required (see pandas_gbq docs).
  • Fix df.to_gbq(...) calls to pandas_gbq.to_gbq(df, ...), which is the updated way to perform table writes (see doc).

Tested it by deploying both BQ and Postgres versions and have verified that it works.

@rishsriv rishsriv requested a review from wongjingping February 5, 2024 07:59
Copy link
Collaborator

@wongjingping wongjingping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice thank you for these improvements!

@wongjingping wongjingping merged commit bb06aa6 into main Feb 5, 2024
2 checks passed
@wongjingping wongjingping deleted the rishabh/reporting branch February 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants