Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where some MySQL tables were in all caps in golden queries #221

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

rishsriv
Copy link
Member

@rishsriv rishsriv commented Sep 18, 2024

Previously, a handful of MySQL queries had the tables location and domain in all caps. This was causing issues with the execution of these queries (atleast in my tests with MySQL 9). An example of these erroneous queries is below

SELECT
  location.city_name,
  COUNT(DISTINCT location.restaurant_id) AS total_count
FROM
  LOCATION
GROUP BY
  location.city_name;

This is now fixed in this PR

Copy link
Contributor

@Muhammad18557 Muhammad18557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing an error with DOMAIN somewhere earlier today!
This should fix it now, thanks :))

Copy link
Collaborator

@wongjingping wongjingping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Muhammad18557 Muhammad18557 merged commit 2b25e9c into main Sep 18, 2024
2 checks passed
@rishsriv rishsriv deleted the rishabh/fix-mysql-all-caps branch September 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants