Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tsql instructions #208

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Translate tsql instructions #208

merged 4 commits into from
Jul 29, 2024

Conversation

wendy-aw
Copy link
Contributor

  • Replace 'some time' and 'last month' in instructions to be a more specific time interval of 30 days
  • Added instructions_to_tsql to translate script and dialects.py which translates the postgres date instructions into tsql.
  • Modified instructions_to_sqlite to perform interval arithmetic without weekday 1

@wendy-aw wendy-aw requested a review from rishsriv July 29, 2024 10:44
rishsriv
rishsriv approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super important and meticulous work on this Wendy! Much, much appreciated!

@rishsriv rishsriv merged commit bc283e5 into main Jul 29, 2024
2 checks passed
@rishsriv rishsriv deleted the wendy/tsql_instr branch July 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishsriv rishsriv rishsriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendy-aw @rishsriv