Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lora arguments to README for setting up vllm server #194

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add lora arguments to README for setting up vllm server #194

merged 2 commits into from
Jul 1, 2024

Conversation

rishsriv
Copy link
Member

@rishsriv rishsriv commented Jul 1, 2024

No description provided.

@rishsriv rishsriv requested review from wongjingping and wendy-aw July 1, 2024 02:00
wongjingping
wongjingping approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@wongjingping wongjingping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README! If you'd like to you can also update the run_model_cot.sh script to allow users to run lora's.

wendy-aw
wendy-aw approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@wendy-aw wendy-aw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@rishsriv
Copy link
Member Author

rishsriv commented Jul 1, 2024

Thanks both! JP I think Wendy's run_models_adapter.sh covers the adapters use-case, so will leave this as it is for now! In the near future, would love to just change the default to a single script by modifying Wendy's script!

@rishsriv rishsriv merged commit b3c6a7c into main Jul 1, 2024
2 checks passed
@rishsriv rishsriv deleted the rishabh/update-readme branch July 1, 2024 02:09
@wongjingping
Copy link
Collaborator

oh yes thanks for reminding me of wendy's script! that'll do 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendy-aw wendy-aw wendy-aw approved these changes

@wongjingping wongjingping wongjingping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishsriv @wongjingping @wendy-aw