Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoRA support for vLLM #169

Merged
merged 2 commits into from
Jun 18, 2024
Merged

LoRA support for vLLM #169

merged 2 commits into from
Jun 18, 2024

Conversation

wendy-aw
Copy link
Contributor

  • LoRA adapters can now be used with vLLM on top of a base model in api_runner.py and vllm_runner.py.
  • Note that for now LoRA ranks must be one of (8, 16, 32, 64)

rishsriv
rishsriv approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thank you :D

@rishsriv rishsriv merged commit ba7aabd into main Jun 18, 2024
2 checks passed
@rishsriv rishsriv deleted the wendy/vllm_adapters branch June 18, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishsriv rishsriv rishsriv approved these changes

@wongjingping wongjingping Awaiting requested review from wongjingping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendy-aw @rishsriv