Error handling overhaul #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defnull
force-pushed
the
feature-errorhandling
branch
from
e4a0b4b to
21c5cbc
Compare
defnull
force-pushed
the
feature-errorhandling
branch
from
21c5cbc to
37b486a
Compare
defnull
force-pushed
the
feature-errorhandling
branch
from
ebc9137 to
f6eaec6
Compare
All methods can carry parse-able form data, including unknown methods. A hard check for POST and PUT makes no sense.
…error. Users can and should check with is_form_request(environ).
Default behavior does not change.
feat: Added HTTP status code info to exceptions
defnull
force-pushed
the
feature-errorhandling
branch
from
f6eaec6 to
28edd69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling needs some work. This PR changes quite a bit:
MultipartErrorinto semantically meaningful sub-exceptions.parse_form_data(..., ignore_errors)parameter that can be used to throw exceptions even in non-strict mode, or to suppress exceptions in strict mode. The default behavior stays the same: Throw in strict mode and ignore in non-struct mode.is_form_request(environ)so you can check if a request is a form request before callingparse_form_dataand trigger an exception.POSTorPUT. The only aspect that reliably identifies form submissions is the content type header.All API changes are backwards compatible. Some behavior changes are not, but they only change undocumented or wrong behavior.