Skip to content

Commit

Permalink
fixes related to bumping duckdb to v0.10.0
Browse files Browse the repository at this point in the history
  • Loading branch information
samansmink committed Feb 14, 2024
1 parent 7e5a727 commit a11bc2c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ EXTENSION_FLAGS=\
-DDUCKDB_EXTENSION_NAMES="iceberg" \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_PATH="$(PROJ_DIR)" \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_LOAD_TESTS=1 \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_SHOULD_LINK=1 \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_INCLUDE_PATH="$(PROJ_DIR)src/include" \
-DDUCKDB_EXTENSION_${EXTENSION_NAME}_TEST_PATH="$(PROJ_DIR)test/sql"

Expand Down
14 changes: 9 additions & 5 deletions scripts/start-rest-catalog.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,15 @@ python3 provision.py
UNPARTITIONED_TABLE_PATH=$(curl -s http://127.0.0.1:8181/v1/namespaces/default/tables/table_unpartitioned | jq -r '."metadata-location"')

SQL=$(cat <<-END
SET s3_access_key_id='admin';
SET s3_secret_access_key='password';
SET s3_endpoint='127.0.0.1:9000';
SET s3_url_style='path';
SET s3_use_ssl=false;
CREATE SECRET (
TYPE S3,
KEY_ID 'admin',
SECRET 'password',
ENDPOINT '127.0.0.1:9000',
URL_STYLE 'path',
USE_SSL 0
);
SELECT * FROM iceberg_scan('${UNPARTITIONED_TABLE_PATH}');
END
Expand Down
2 changes: 2 additions & 0 deletions test/sql/iceberg_snapshots.test
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ SELECT * FROM ICEBERG_SNAPSHOTS('data/iceberg/lineitem_iceberg');
----
Catalog Error

require notwindows

require iceberg

query IIII
Expand Down

0 comments on commit a11bc2c

Please sign in to comment.