Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moved theme to config #21

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

Onizuka-wl
Copy link
Contributor

@Onizuka-wl Onizuka-wl commented Oct 2, 2024

Describe your changes

  • Moved Theme folder to config
  • Added new CustomTheme type
  • Added themes on getConfig function (Rainbow, main, mui)

Issue ticket number and link

PRIUI-278 - https://linear.app/defi-wonderland/issue/PRIUI-278/move-theme-folder-to-config-folder

closes PRIUI-278

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • I have conducted a QA.
  • If it is a core feature, I have included comprehensive tests.

Copy link

linear bot commented Oct 2, 2024

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-react-boilerplate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 8:42pm

src/types/Theme.ts Outdated Show resolved Hide resolved
src/types/Theme.ts Outdated Show resolved Hide resolved
0xArdy
0xArdy previously approved these changes Oct 2, 2024
Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/providers/ThemeProvider.tsx Outdated Show resolved Hide resolved
src/utils/getTheme.ts Outdated Show resolved Hide resolved
src/config/index.ts Outdated Show resolved Hide resolved
src/config/Theme/index.ts Outdated Show resolved Hide resolved
src/types/Theme.ts Outdated Show resolved Hide resolved
Copy link

@0xShishigami 0xShishigami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@Onizuka-wl Onizuka-wl merged commit f9b9158 into dev Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants