Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: statements in format #1598

Merged
merged 3 commits into from
Dec 17, 2024
Merged

chore: statements in format #1598

merged 3 commits into from
Dec 17, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Too many statements in format.ts

Related Issue

Fixes #1596

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner December 17, 2024 20:28
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (2a06363) to head (1254067).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
+ Coverage   81.09%   81.24%   +0.14%     
==========================================
  Files          41       42       +1     
  Lines        1947     1962      +15     
  Branches      422      424       +2     
==========================================
+ Hits         1579     1594      +15     
  Misses        340      340              
  Partials       28       28              
Files with missing lines Coverage Δ
src/cli/format.helpers.ts 100.00% <100.00%> (ø)

Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracts out shared code and ensures we have test coverage for previously untested code at the unit level, good PR

@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 80127f6 Dec 17, 2024
48 checks passed
@cmwylie19 cmwylie19 deleted the 1596 branch December 17, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

peprFormat has too many statements
2 participants