refactor: resolve eslint warnings (complexity) - src/lib/filter/filterNoMatchReason.ts

[btlghrants]

Describe what should be investigated or refactored

Refactor of src/lib/filter/filterNoMatchReason.ts to reduce complexity warnings:

/pepr/src/lib/filter/filterNoMatchReason.ts
  32:8  warning  Function 'filterNoMatchReason' has a complexity of 13. Maximum allowed is 10  complexity

Additional context

Fixes #1584
In support of #1248

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (cd255d5) to head (95bdf8e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   81.30%   81.13%   -0.18%     
==========================================
  Files          42       41       -1     
  Lines        1952     1945       -7     
  Branches      451      429      -22     
==========================================
- Hits         1587     1578       -9     
+ Misses        363      339      -24     
- Partials        2       28      +26     

Files with missing lines	Coverage Δ
src/lib/filter/filter.ts	100.00% <100.00%> (ø)
src/lib/processors/watch-processor.ts	78.64% <100.00%> (ø)

... and 7 files with indirect coverage changes

[cmwylie19]

The logic is sound but if we merge in #1364 we are going to be missing many return types:

/pepr/src/lib/filter/filter.ts
   67:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   68:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   69:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   70:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   71:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   72:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   73:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   74:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   75:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   76:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   77:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   78:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   79:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   80:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   81:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   82:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  113:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  114:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  115:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  116:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  117:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  118:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  119:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  120:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  121:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  122:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  123:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  124:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type

[btlghrants]

The logic is sound but if we merge in #1364 we are going to be missing many return types:

/pepr/src/lib/filter/filter.ts
   67:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   68:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   69:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   70:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   71:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   72:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   73:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   74:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   75:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   76:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   77:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   78:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   79:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   80:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   81:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   82:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  113:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  114:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  115:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  116:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  117:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  118:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  119:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  120:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  121:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  122:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  123:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  124:8  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type

I think... I do not value the explicit-function-return-type rule and I would love to turn it off: it's a hammer that requires return types even when type inference & local type defs will more-the-suffice (...without making us c&p return type class names that are 75% the length of the tiny, inline funcs we're trying to declare, ugh).

That said... I totally forgot that we planned to turn this rule on, so until we can talk about turning it off for-realz, lemme just go add the types back in. Blerg.

[cmwylie19]

very nice!