Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add return types to untyped functions #1560

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

samayer12
Copy link
Collaborator

Description

Adds typing to untyped functions

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1551

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (94b5833) to head (05a6cf0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
+ Coverage   78.81%   78.82%   +0.01%     
==========================================
  Files          41       41              
  Lines        1803     1804       +1     
  Branches      422      403      -19     
==========================================
+ Hits         1421     1422       +1     
- Misses        350      380      +30     
+ Partials       32        2      -30     
Files with missing lines Coverage Δ
src/lib/assets/helm.ts 92.30% <100.00%> (ø)
src/lib/assets/pods.ts 94.64% <100.00%> (+0.09%) ⬆️

... and 8 files with indirect coverage changes

@samayer12 samayer12 changed the title 1551 more return types chore: add return types to untyped functions Dec 10, 2024
@samayer12 samayer12 marked this pull request as ready for review December 10, 2024 23:43
@samayer12 samayer12 requested a review from a team as a code owner December 10, 2024 23:43
@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit a7989f7 Dec 11, 2024
48 of 49 checks passed
@cmwylie19 cmwylie19 deleted the 1551-more-return-types branch December 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

return types on yaml.ts webhooks.ts, pods.ts, helm.ts and destroy.ts
2 participants