Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return types on schedule #1505

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: return types on schedule #1505

merged 1 commit into from
Dec 4, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Adds return types to schedule to unify typing

Related Issue

Fixes #1454

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner December 4, 2024 13:46
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (b74496c) to head (81a36ef).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1505   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files          39       39           
  Lines        1720     1720           
  Branches      404      388   -16     
=======================================
  Hits         1361     1361           
- Misses        330      357   +27     
+ Partials       29        2   -27     
Files with missing lines Coverage Δ
src/lib/schedule.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@cmwylie19 cmwylie19 added this to the v0.41.0 milestone Dec 4, 2024
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, straight-forward return type adds.

@btlghrants btlghrants added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit b75ac42 Dec 4, 2024
45 checks passed
@btlghrants btlghrants deleted the 1454 branch December 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Return types in schedule.ts
2 participants