Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make load test err msg explicit #1478

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

btlghrants
Copy link
Collaborator

Description

Overnight load test failed just as it was beginning -- 2.5 min into a 3 hr expected runtime. Diagnosing failure let to discovery of an unhelpful message: The promise rejected with the reason "#<Object>".

This PR adds the catch block necessary to see what actually went wrong.

Load test start: 2024-11-22T05:09:47.892Z
{
  "module": "/home/runner/work/pepr/pepr/pepr-excellent-examples/hello-pepr-load",
  "manifest": "/home/runner/work/pepr/pepr/pepr-excellent-examples/hello-pepr-load/capabilities/configmap.yaml"
}
{
  "actInterval": "1m",
  "actIntensity": 4000,
  "audInterval": "1s",
  "clusterName": "pepr-load-cluster",
  "duration": "1h",
  "outputDir": "/home/runner/work/pepr/pepr/pepr/load",
  "settle": "2h",
  "stagger": "5s"
}

UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "#<Object>".
    at throwUnhandledRejectionsMode (node:internal/process/promises:389:7)
    at processPromiseRejections (node:internal/process/promises:470:17)
    at processTicksAndRejections (node:internal/process/task_queues:96:[32](https://github.com/defenseunicorns/pepr/actions/runs/11966824488/job/33363083364#step:16:33)) {
  code: 'ERR_UNHANDLED_REJECTION'
}
↓
Error: Process completed with exit code 1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants added the Testing Testing label Nov 22, 2024
@btlghrants btlghrants added this to the v0.41.0 milestone Nov 22, 2024
@btlghrants btlghrants self-assigned this Nov 22, 2024
@btlghrants btlghrants marked this pull request as ready for review November 22, 2024 14:36
@btlghrants btlghrants requested a review from a team as a code owner November 22, 2024 14:36
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (d2dec12) to head (2b0f82d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1478   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          37       37           
  Lines        1717     1717           
  Branches      410      402    -8     
=======================================
  Hits         1349     1349           
+ Misses        366      339   -27     
- Partials        2       29   +27     

see 7 files with indirect coverage changes

---- 🚨 Try these New Features:

@cmwylie19 cmwylie19 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit adf7c37 Nov 22, 2024
47 checks passed
@cmwylie19 cmwylie19 deleted the load_test_err_handling branch November 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Testing
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants