Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract deployment check functions to new file for ease of maintenance #1472

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

samayer12
Copy link
Collaborator

Description

helpers.ts is bloated and adds to maintenance overhead. By moving some deployment-related functions to a separate file we reduce the cognitive load faced by any developer working withing helpers.ts and associated tests.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1397

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 requested a review from a team as a code owner November 21, 2024 22:03
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (80ca101) to head (0eb3f1e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/deploymentChecks.ts 92.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
+ Coverage   78.55%   78.56%   +0.01%     
==========================================
  Files          36       37       +1     
  Lines        1716     1717       +1     
  Branches      386      411      +25     
==========================================
+ Hits         1348     1349       +1     
+ Misses        366      339      -27     
- Partials        2       29      +27     
Files with missing lines Coverage Δ
src/lib/helpers.ts 98.06% <ø> (+0.85%) ⬆️
src/lib/deploymentChecks.ts 92.00% <92.00%> (ø)

... and 7 files with indirect coverage changes

---- 🚨 Try these New Features:

@cmwylie19 cmwylie19 added this to the v0.41.0 milestone Nov 22, 2024
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmwylie19 cmwylie19 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit d2dec12 Nov 22, 2024
46 checks passed
@cmwylie19 cmwylie19 deleted the 1397-split-helpers branch November 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants