Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate images from registry via Pepr (ADR) #1256

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

btlghrants
Copy link
Collaborator

Description

Working through how we might accomplish validating image signatures against pubkeys derived from the OCI registries that serve them.

Relates to #1240

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (b11d6ca) to head (5e2bb0e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1256   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          29       29           
  Lines        1411     1411           
  Branches      329      329           
=======================================
  Hits         1211     1211           
  Misses        182      182           
  Partials       18       18           

@btlghrants btlghrants changed the title spike: validate images from registry via Pepr chore: validate images from registry via Pepr Oct 10, 2024
@btlghrants btlghrants self-assigned this Oct 10, 2024
@btlghrants btlghrants changed the title chore: validate images from registry via Pepr chore: validate images from registry via Pepr (ADR) Oct 11, 2024
@btlghrants btlghrants marked this pull request as ready for review October 11, 2024 20:00
@btlghrants btlghrants requested a review from a team as a code owner October 11, 2024 20:00
adr/0014-admission-verify-img-sigs.md Outdated Show resolved Hide resolved
@cmwylie19 cmwylie19 merged commit 6bbda7f into main Oct 11, 2024
16 of 18 checks passed
@cmwylie19 cmwylie19 deleted the 1240_spike_img_sigs_from_reg branch October 11, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants