-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: validate images from registry via Pepr (ADR) #1256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 29 29
Lines 1411 1411
Branches 329 329
=======================================
Hits 1211 1211
Misses 182 182
Partials 18 18 |
btlghrants
changed the title
spike: validate images from registry via Pepr
chore: validate images from registry via Pepr
Oct 10, 2024
btlghrants
changed the title
chore: validate images from registry via Pepr
chore: validate images from registry via Pepr (ADR)
Oct 11, 2024
cmwylie19
reviewed
Oct 11, 2024
cmwylie19
reviewed
Oct 11, 2024
cmwylie19
requested changes
Oct 11, 2024
Co-authored-by: Case Wylie <[email protected]>
cmwylie19
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working through how we might accomplish validating image signatures against pubkeys derived from the OCI registries that serve them.
Relates to #1240
Type of change
Checklist before merging