Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rbac overrides in package.json #1251

Closed
wants to merge 38 commits into from
Closed

feat: rbac overrides in package.json #1251

wants to merge 38 commits into from

Conversation

schaeferka
Copy link
Contributor

Description

We want to leverage package.json to defined RBAC settings that will work with RBAC and create an excellent example test.

Describe the solution you'd like
Given we want to create a reproducible way to generate scoped RBAC
When we define the RBAC in package.json and run a build
Then we have our customized RBAC
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #814

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka added this to the v0.38.0 milestone Oct 9, 2024
@schaeferka schaeferka self-assigned this Oct 9, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 9, 2024 20:32
@schaeferka schaeferka linked an issue Oct 9, 2024 that may be closed by this pull request
1 task
@schaeferka schaeferka marked this pull request as draft October 9, 2024 20:32
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (47bdfc3) to head (627b5ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/assets/helm.ts 50.00% 1 Missing ⚠️
src/lib/assets/rbac.ts 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
+ Coverage   85.77%   85.99%   +0.21%     
==========================================
  Files          29       30       +1     
  Lines        1406     1442      +36     
  Branches      328      339      +11     
==========================================
+ Hits         1206     1240      +34     
+ Misses        198      184      -14     
- Partials        2       18      +16     
Files with missing lines Coverage Δ
src/lib/helpers.ts 97.19% <100.00%> (+0.04%) ⬆️
src/lib/module.ts 81.25% <ø> (ø)
src/lib/types.ts 100.00% <ø> (ø)
src/lib/assets/helm.ts 92.30% <50.00%> (-7.70%) ⬇️
src/lib/assets/rbac.ts 96.77% <93.75%> (ø)

... and 4 files with indirect coverage changes

@cmwylie19 cmwylie19 modified the milestones: v0.38.0, v0.39.0 Oct 15, 2024
src/lib/assets/helm.ts Outdated Show resolved Hide resolved
@schaeferka schaeferka marked this pull request as ready for review October 17, 2024 22:51
journey/pepr-build.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
cmwylie19
cmwylie19 previously approved these changes Oct 24, 2024
journey/pepr-build-wasm.ts Show resolved Hide resolved
src/lib/assets/deploy.ts Outdated Show resolved Hide resolved
src/lib/assets/rbac.ts Outdated Show resolved Hide resolved
samayer12
samayer12 previously approved these changes Oct 24, 2024
src/lib/assets/deploy.ts Outdated Show resolved Hide resolved
src/lib/assets/rbac.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need just one second on this.

src/lib/types.ts Outdated Show resolved Hide resolved
src/lib/module.ts Outdated Show resolved Hide resolved
cmwylie19
cmwylie19 previously approved these changes Oct 24, 2024
@cmwylie19
Copy link
Collaborator

The runners are not refreshing the code, the complaints are due to a change in KFC that was needed to unblock CI but no longer exists in this code base.

@cmwylie19 cmwylie19 closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Have a way to create overrides for RBAC in a source file.
3 participants