Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: kfc automation scripts and workflow files #1223

Merged
merged 38 commits into from
Oct 15, 2024
Merged

chore: kfc automation scripts and workflow files #1223

merged 38 commits into from
Oct 15, 2024

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Oct 4, 2024

Description

KFC Automation Script and Workflow files

  • Run e2e/soak with KFC release candidate
  • Local dev with with KFC release candidate, ie, npx pepr dev
  • Bring in KFC dist and src to Pepr node_modules developing Pepr against new KFC feature

Related Issue

Fixes #1217

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 requested a review from a team as a code owner October 4, 2024 12:12
@cmwylie19 cmwylie19 changed the title 1217 chore: KFC Automation Script and Workflow files Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (0f1a47c) to head (e27f2cc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1223   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          29       29           
  Lines        1411     1411           
  Branches      304      329   +25     
=======================================
  Hits         1211     1211           
  Misses        198      198           
  Partials        2        2           

@cmwylie19 cmwylie19 changed the title chore: KFC Automation Script and Workflow files chore: kfc automation scripts and workflow files Oct 4, 2024
@cmwylie19 cmwylie19 marked this pull request as draft October 9, 2024 20:57
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 marked this pull request as ready for review October 10, 2024 18:01
@cmwylie19 cmwylie19 added this to the v0.38.0 milestone Oct 10, 2024
hack/kfc-dev.js Outdated Show resolved Hide resolved
hack/kfc-dev.js Show resolved Hide resolved
hack/kfc-dev.js Outdated Show resolved Hide resolved
hack/kfc-dev.test.js Outdated Show resolved Hide resolved
hack/kfc-dev.test.js Outdated Show resolved Hide resolved
cmwylie19 and others added 2 commits October 10, 2024 15:43
hack/kfc-dev.test.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple Q's on the commander.js script API.

hack/kfc-dev.js Outdated Show resolved Hide resolved
.github/workflows/pepr-excellent-examples.yml Outdated Show resolved Hide resolved
.github/workflows/soak.yaml Outdated Show resolved Hide resolved
hack/kfc-dev.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmwylie19 cmwylie19 enabled auto-merge (squash) October 15, 2024 12:42
@cmwylie19 cmwylie19 merged commit 50708e0 into main Oct 15, 2024
44 of 45 checks passed
@cmwylie19 cmwylie19 deleted the 1217 branch October 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

automate bringing in dev versions of KFC into Pepr
2 participants