feat: included tests for utils package #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- included tests for utils package Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
mjnagel
as code owners
UncleGedd
reviewed
Mar 26, 2024
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| if got := TemplateString(tt.args.templateMap, tt.args.s); got != tt.want { |
There was a problem hiding this comment.
Instead of manually rolling the checks, in other tests we use the require function from testify which simpliies this logic
UncleGedd
reviewed
Mar 26, 2024
| withs: map[string]string{"test-input": "value1"}, | ||
| }, | ||
| want: []types.Action{ | ||
| {TaskReference: "test-task", With: map[string]string{"test-input": "value1"}}, |
There was a problem hiding this comment.
I may be missing it, but where does the templating occur in this test (docs for reference)
UncleGedd
reviewed
Mar 26, 2024
| t.Errorf("TemplateTaskActionsWithInputs() error = %v, wantErr %v", err, tt.wantErr) | ||
| return | ||
| } | ||
| if diff := cmp.Diff(tt.want, got, cmpopts.IgnoreFields(types.Action{}, "ZarfComponentAction")); diff != "" { |
There was a problem hiding this comment.
This is another area where I think require is a bit cleaner with less code; maybe you could compare just a single field in the Action instead of doing the deep inspection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging