-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api)!: initial integration of registry1 api flavor #920
Conversation
✅ Deploy Preview for leapfrogai-docs canceled.
|
Depends on documentation updates from #902, and then one more update on top of that documentation. |
…pi-registry1-flavor
Pending @YrrepNoj approval too! Thanks @gphorvath and @CollectiveUnicorn |
7a019e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change request and one pondering on if we should consider this PR a 'breaking' change.
8a41f46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the updates.
OVERVIEW
Adds the Registry1 flavor of the LeapfrogAI API to the developer workflow and increases Helm chart and Dockerfile standard (foreshadowing upcoming Helm and Dockerfile linting PR).
Once all other
registry1
flavored images are published to IronBank, thee2e-registry1-weekly.yaml
will need to have access to auds-bundle.yaml
that points to packages created using theregistry1.dso.mil
container registry. For now, as each component comes online, we can use theyq
commands to temporarily modify each one within the workflow:BREAKING CHANGES
leapfrogai-api
instead ofapi
, following the convention of using the Helm chart name for template helpersIMAGE_VERSION
instead ofLEAPFROGAI_IMAGE_VERSION
, to align the build process with all other components/packagesCHANGES
FLAVOR
flag to the Makefile, defaulting toupstream
registry1
Zarf package flavoring for the API