Skip to content

Commit

Permalink
fix: correct fsGroup configuration in various deployments (#974)
Browse files Browse the repository at this point in the history
* fix: invalid fsGroup config in vllm chart
* fix: invalid fsGroup config in whisper chart
* fix: invalid fsGroup config in text-embeddings chart
* fix: invalid fsGroup config in llama chart
* fix: invalid fsGroup config in various job manifests
* fix: invalid fsGroup config in api chart
* fix: invalid fsGroup config in repeater chart
  • Loading branch information
YrrepNoj authored Sep 3, 2024
1 parent c191b54 commit 86766db
Show file tree
Hide file tree
Showing 13 changed files with 11 additions and 13 deletions.
1 change: 0 additions & 1 deletion packages/api/chart/templates/api/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ spec:
securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532
volumeMounts:
- name: api-model
mountPath: /config
Expand Down
3 changes: 2 additions & 1 deletion packages/api/chart/templates/migration-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ spec:
securityContext:
runAsUser: {{ .Values.image.securityContext.runAsUser }}
runAsGroup: {{ .Values.image.securityContext.runAsGroup }}
fsGroup: {{ .Values.image.securityContext.fsGroup }}
securityContext:
fsGroup: {{ .Values.image.securityContext.fsGroup }}
restartPolicy: Never
backoffLimit: 4
1 change: 0 additions & 1 deletion packages/llama-cpp-python/chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ spec:
securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532
# This command looks for the Zarf "data injection marker" which is a timestamped file that is injected after everything else and marks the injection as complete.
command:
[
Expand Down
2 changes: 1 addition & 1 deletion packages/llama-cpp-python/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ podAnnotations: {}

podSecurityContext:
runAsNonRoot: true
fsGroup: 65532

securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532

service:
type: ClusterIP
Expand Down
2 changes: 1 addition & 1 deletion packages/repeater/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ podAnnotations: {}

podSecurityContext:
runAsNonRoot: true
fsGroup: 65532

securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532

service:
type: ClusterIP
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ spec:
securityContext:
runAsUser: {{ .Values.leapfrogai.securityContext.runAsUser }}
runAsGroup: {{ .Values.leapfrogai.securityContext.runAsGroup }}
fsGroup: {{ .Values.leapfrogai.securityContext.fsGroup }}
securityContext:
fsGroup: {{ .Values.leapfrogai.securityContext.fsGroup }}
restartPolicy: Never
backoffLimit: 4
1 change: 0 additions & 1 deletion packages/text-embeddings/chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ spec:
securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532
# This command looks for the Zarf "data injection marker" which is a timestamped file that is injected after everything else and marks the injection as complete.
command:
[
Expand Down
2 changes: 1 addition & 1 deletion packages/text-embeddings/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ podAnnotations: {}

podSecurityContext:
runAsNonRoot: true
fsGroup: 65532

securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532

service:
type: ClusterIP
Expand Down
3 changes: 2 additions & 1 deletion packages/ui/chart/templates/ui/migration-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ spec:
securityContext:
runAsUser: {{ .Values.image.securityContext.runAsUser }}
runAsGroup: {{ .Values.image.securityContext.runAsGroup }}
fsGroup: {{ .Values.image.securityContext.fsGroup }}
securityContext:
fsGroup: {{ .Values.image.securityContext.fsGroup }}
restartPolicy: Never
backoffLimit: 4
1 change: 0 additions & 1 deletion packages/vllm/chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ spec:
securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532
# This command looks for the Zarf "data injection marker" which is a timestamped file that is injected after everything else and marks the injection as complete.
command:
[
Expand Down
2 changes: 1 addition & 1 deletion packages/vllm/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ podAnnotations: {}

podSecurityContext:
runAsNonRoot: true
fsGroup: 65532

securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532

service:
type: ClusterIP
Expand Down
1 change: 0 additions & 1 deletion packages/whisper/chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ spec:
securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532
# This command looks for the Zarf "data injection marker" which is a timestamped file that is injected after everything else and marks the injection as complete.
command:
[
Expand Down
2 changes: 1 addition & 1 deletion packages/whisper/chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ podAnnotations: {}

podSecurityContext:
runAsNonRoot: true
fsGroup: 65532

securityContext:
runAsUser: 65532
runAsGroup: 65532
fsGroup: 65532

service:
type: ClusterIP
Expand Down

0 comments on commit 86766db

Please sign in to comment.