Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PyPDFToDocument - add new customization parameters #8574

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 22, 2024

Related Issues

Proposed Changes:

How did you test it?

CI, new test

Notes for the reviewer

I don't particularly like the addition of all of these new init parameters, but we have already discussed and discarded the idea of having a single extraction_kwargs dict.

Checklist

@github-actions github-actions bot added type:documentation Improvements on the docs topic:tests labels Nov 22, 2024
@anakin87 anakin87 marked this pull request as ready for review November 22, 2024 17:31
@anakin87 anakin87 requested review from a team as code owners November 22, 2024 17:31
@anakin87 anakin87 requested review from dfokina and vblagoje and removed request for a team November 22, 2024 17:31
@anakin87 anakin87 added this to the 2.8.0 milestone Nov 22, 2024
Base automatically changed from pypdf-deprecate-custom-converter to main November 26, 2024 13:47
@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12033758738

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 90.349%

Files with Coverage Reduction New Missed Lines %
components/converters/pypdf.py 6 93.18%
Totals Coverage Status
Change from base Build 12031967571: 0.03%
Covered Lines: 8014
Relevant Lines: 8870

💛 - Coveralls

Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine only minor nitpicking comments.
Maintaining compatibility on this one is going to be hard with so many fields. Any other way to deal with these in less breaking manner? Perhaps some config dictionary or something....

haystack/components/converters/pypdf.py Outdated Show resolved Hide resolved
haystack/components/converters/pypdf.py Outdated Show resolved Hide resolved
@anakin87
Copy link
Member Author

Perhaps some config dictionary or something....

This was my original idea but then we discarded it to keep more control on accepted parameters and serialization.

@anakin87 anakin87 merged commit fb42c03 into main Nov 26, 2024
18 checks passed
@anakin87 anakin87 deleted the pypdf-add-customization-params branch November 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants