feat: Add store_full_path to converters (1/3)

[Amnah199]

Related Issues

• partial fix for File_path in meta should optionally be just the filename #8440

Proposed Changes:

Add a new parameter to the __init__ method to allow users to toggle whether the file_path in metadata stores the complete file path or only the base file name. A DeprecationWarning is generated about the upcoming change in file_path storage behavior in the next release.

How did you test it?

Added new test for checking the parameter function

Notes for the reviewer

This is 1/3 PRs that will add the same change to other converters.

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 11972752772

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 90.275%

---

Totals
Change from base Build 11972705853:	0.03%
Covered Lines:	7872
Relevant Lines:	8720

---

💛 - Coveralls

[julian-risch]

The changes look quite good to me. I suggest that we move the store_full_path parameter from the run method to the init method instead. I don't see a need to change the store_full_path for different runs of the same component. If it turns out that's needed, we can add it later. For now, I would only add the parameter to the init method. Happy to discuss.

Once this is done and we merged the PR, could you please add a 2.9 milestone and add an issue about changing the default and removing the deprecation warning to the milestone please?

[Amnah199]

I agree with having store_full_path in init. But do you think we should keep it in both? My reason to include it in run was that user could decide at the time of supplying sources param if he wanted to store only file names for some of the sources.

[julian-risch]

LGTM! 👍 We can add the parameter to the run methods to if we see requests for that. Right now, I don't see why a user would want to have the full path in meta for some files and only the file name for some other files in the same pipeline. Let's see.