-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test charts #262
base: dev
Are you sure you want to change the base?
Test charts #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should be a separate test from test_main
-- it's supposed to be more of an integration test that checks the entire pipeline from data collection to statistics display.
Also, this new test should clear the clickhouse db and fill it with new data like test_tutorial
.
I don't understand why the tests pass. According to logs
And I don't see any calls to On the same note,
Superset may have had a different configuration stored in the postgres db Also, I noticed that when I introduced some changes to charts in #227 I didn't update the I also imagined that chart testing would be more meaningful than comparing hundreds of lines of raw data. Something along the lines of
Or in order to test for no context-leakage: We could discuss which specific tests we want tomorrow. |
e6986d5
to
73d8d69
Compare
Description
Test charts; add chart test data
Checklist