Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #750

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Update README.md #750

wants to merge 2 commits into from

Conversation

pee8379
Copy link
Contributor

@pee8379 pee8379 commented Jun 8, 2022

'pert_box' dose not seems to work as percentage.

amcadmus and others added 2 commits April 26, 2022 16:45
It seems 'pert_box' dose not work as percentage.
@njzjz njzjz changed the base branch from master to devel June 8, 2022 07:56
Copy link
Collaborator

@AnguseZhang AnguseZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Though, I do think pert_box serves as changing the percentage, instead of an absolute length for box length. (See

def gen_random_emat(etmax, diag=0):
). How does it behave in your circumstance?

@pee8379
Copy link
Contributor Author

pee8379 commented Jun 8, 2022

Right. I misunderstood, only saw emat = emat + np.eye(3) and not
cell = np.dot(cell0, gen_random_emat(etmax, diag))
part.

I originally had a interest this part, because some of my POSCARs generated by init_bulk has highly deformed cell.
does
"pert_box": 1
means 1% of changing in box? or should it be 0.01 to get 1% of change?

Thanks.

@amcadmus amcadmus requested a review from AnguseZhang June 22, 2022 23:48
@HuangJiameng
Copy link
Collaborator

I see what you mean, maybe "ratio" is more appropriate than "percentage"
see 'pert_cmd = 'python3 ' + pert_cmd + ' -etmax %f -ofmt %s %s %d %f > /dev/null' %(pert_box, fp_style, poscar_name, pert_numb, pert_atom)' in https://github.com/deepmodeling/dpgen/blob/0767dce7cad29367edb2e4a55fd0d8724dbda642/dpgen/data/gen.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants