Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: remove redundant checks on data integrity #4433

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Perf: remove redundant checks on data integrity #4433

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36884d2
Perf: remove redundant checks on data integrity
caic99 Nov 27, 2024
beab41c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 27, 2024
0e1944a
Update deepmd/utils/data_system.py
caic99 Nov 27, 2024
b093fd7
add error message
caic99 Nov 29, 2024
90ffb61
Update deepmd/utils/data_system.py
caic99 Nov 30, 2024
7331472
remove redundant checks
caic99 Nov 30, 2024
fd59449
Update deepmd/utils/data_system.py
caic99 Nov 30, 2024
89a3882
fix ut
caic99 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions deepmd/utils/data_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
from deepmd.utils.out_stat import (
compute_stats_from_redu,
)
from deepmd.utils.path import (
DPPath,
)

log = logging.getLogger(__name__)

Expand Down Expand Up @@ -758,20 +755,9 @@
help_msg = "Please check your setting for data systems"
# check length of systems
if len(systems) == 0:
msg = "cannot find valid a data system"
msg = "Can not find any valid data systems"

Check warning on line 758 in deepmd/utils/data_system.py

View check run for this annotation

Codecov / codecov/patch

deepmd/utils/data_system.py#L758 

Added line #L758 was not covered by tests
caic99 marked this conversation as resolved.
Show resolved Hide resolved
log.fatal(msg)
raise OSError(msg, help_msg)
# roughly check all items in systems are valid
for ii in systems:
ii = DPPath(ii)
if not ii.is_dir():
msg = f"dir {ii} is not a valid dir"
log.fatal(msg)
raise OSError(msg, help_msg)
if not (ii / "type.raw").is_file():
msg = f"dir {ii} is not a valid data system dir"
log.fatal(msg)
raise OSError(msg, help_msg)
return systems


Expand Down