Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jax): handle DPA-2 pbc/nopbc without mapping #4363

Merged
merged 4 commits into from
Nov 19, 2024

add test

c374f39
Select commit
Loading
Failed to load commit list.
Merged

fix(jax): handle DPA-2 pbc/nopbc without mapping #4363

add test
c374f39
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 0s

84.54% (+0.03%) compared to 0ad4289

View this Pull Request on Codecov

84.54% (+0.03%) compared to 0ad4289

Details

Codecov Report

Attention: Patch coverage is 97.95918% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (0ad4289) to head (c374f39).

Files with missing lines Patch % Lines
source/api_cc/src/DeepPotJAX.cc 80.00% 1 Missing and 1 partial ⚠️
deepmd/jax/jax2tf/serialization.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #4363      +/-   ##
==========================================
+ Coverage   84.50%   84.54%   +0.03%     
==========================================
  Files         596      597       +1     
  Lines       56665    56813     +148     
  Branches     3459     3487      +28     
==========================================
+ Hits        47884    48031     +147     
- Misses       7654     7655       +1     
  Partials     1127     1127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.