-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin array-api-strict to <2.1.1 #4326
Conversation
xref: data-apis/array-api-strict#85 Signed-off-by: Jinzhe Zeng <[email protected]>
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
pyproject.toml (1)
88-89
: LGTM! Consider documenting this constraint in CHANGELOG.mdThe version pinning of
array-api-strict
to<2.1.1
is well-justified with the referenced issue. This is a good preventive measure to maintain compatibility.Consider adding an entry to CHANGELOG.md to document this dependency constraint for future reference.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4326 +/- ##
==========================================
- Coverage 84.42% 84.33% -0.10%
==========================================
Files 570 570
Lines 53107 53107
Branches 3059 3059
==========================================
- Hits 44836 44788 -48
- Misses 7307 7354 +47
- Partials 964 965 +1 ☔ View full report in Codecov by Sentry. |
See #4325.
Summary by CodeRabbit