Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jax): build nlist in the SavedModel & fix nopbc for StableHLO and SavedModel #4318

Merged
merged 32 commits into from
Nov 11, 2024

clean up default values

84cb819
Select commit
Loading
Failed to load commit list.
Merged

feat(jax): build nlist in the SavedModel & fix nopbc for StableHLO and SavedModel #4318

clean up default values
84cb819
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2024 in 0s

84.09% (-0.33%) compared to 914b1f9

View this Pull Request on Codecov

84.09% (-0.33%) compared to 914b1f9

Details

Codecov Report

Attention: Patch coverage is 32.89474% with 153 lines in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (914b1f9) to head (84cb819).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
deepmd/jax/jax2tf/nlist.py 9.41% 77 Missing ⚠️
deepmd/jax/jax2tf/transform_output.py 12.50% 35 Missing ⚠️
deepmd/jax/jax2tf/region.py 29.16% 17 Missing ⚠️
deepmd/jax/jax2tf/make_model.py 38.09% 13 Missing ⚠️
deepmd/jax/jax2tf/serialization.py 66.66% 8 Missing ⚠️
deepmd/jax/model/hlo.py 77.77% 2 Missing ⚠️
deepmd/jax/jax2tf/tfmodel.py 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #4318      +/-   ##
==========================================
- Coverage   84.42%   84.09%   -0.33%     
==========================================
  Files         570      574       +4     
  Lines       53078    53297     +219     
  Branches     3054     3054              
==========================================
+ Hits        44810    44821      +11     
- Misses       7309     7515     +206     
- Partials      959      961       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov