-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): fix skip_dp
#4111
fix(tests): fix skip_dp
#4111
Conversation
Signed-off-by: Jinzhe Zeng <[email protected]>
WalkthroughWalkthroughThe pull request introduces changes to the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4111 +/- ##
==========================================
- Coverage 83.02% 83.01% -0.01%
==========================================
Files 532 532
Lines 52164 52164
Branches 3030 3030
==========================================
- Hits 43308 43305 -3
- Misses 7910 7912 +2
- Partials 946 947 +1 ☔ View full report in Codecov by Sentry. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated the test skipping logic across multiple test files to reference the correct condition for skipping tests, enhancing the accuracy of test execution. - **Tests** - Adjusted the `skip_dp` method in various test classes to improve the control flow and alignment with specific testing scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <[email protected]>
Summary by CodeRabbit
skip_dp
method in various test classes to improve the control flow and alignment with specific testing scenarios.