Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pt): improve out-of-memory handling #3836

Merged
merged 4 commits into from
May 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion deepmd/pt/utils/auto_batch_size.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,17 @@
e : Exception
Exception
"""
return isinstance(e, RuntimeError) and "CUDA out of memory." in e.args[0]
# several sources think CUSOLVER_STATUS_INTERNAL_ERROR is another out-of-memory error,
# such as https://github.com/JuliaGPU/CUDA.jl/issues/1924
# (the meaningless error message should be considered as a bug in cusolver)
if isinstance(e, RuntimeError) and (

Check warning on line 58 in deepmd/pt/utils/auto_batch_size.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pt/utils/auto_batch_size.py#L58

Added line #L58 was not covered by tests
"CUDA out of memory." in e.args[0]
or "cusolver error: CUSOLVER_STATUS_INTERNAL_ERROR" in e.args[0]
):
# Release all unoccupied cached memory
torch.cuda.empty_cache()
return True
return False

Check warning on line 65 in deepmd/pt/utils/auto_batch_size.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pt/utils/auto_batch_size.py#L63-L65

Added lines #L63 - L65 were not covered by tests

def execute_all(
self, callable: Callable, total_size: int, natoms: int, *args, **kwargs
Expand Down