Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor update_sel and save min_nbor_dist #3829

Merged
merged 14 commits into from
May 31, 2024

fix type hints

88c5219
Select commit
Loading
Failed to load commit list.
Merged

refactor: refactor update_sel and save min_nbor_dist #3829

fix type hints
88c5219
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 28, 2024 in 1s

81.14% (-1.34%) compared to 3f6e511

View this Pull Request on Codecov

81.14% (-1.34%) compared to 3f6e511

Details

Codecov Report

Attention: Patch coverage is 69.58763% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 81.14%. Comparing base (3f6e511) to head (88c5219).
Report is 3 commits behind head on devel.

Current head 88c5219 differs from pull request most recent head 27ea218

Please upload reports for the commit 27ea218 to get more accurate results.

Files Patch % Lines
deepmd/dpmodel/descriptor/hybrid.py 18.18% 9 Missing ⚠️
deepmd/tf/descriptor/hybrid.py 18.18% 9 Missing ⚠️
deepmd/dpmodel/descriptor/dpa2.py 28.57% 5 Missing ⚠️
deepmd/pt/entrypoints/main.py 58.33% 5 Missing ⚠️
deepmd/pt/model/descriptor/dpa2.py 28.57% 5 Missing ⚠️
deepmd/dpmodel/descriptor/dpa1.py 40.00% 3 Missing ⚠️
deepmd/tf/model/pairtab.py 40.00% 3 Missing ⚠️
deepmd/dpmodel/descriptor/se_e2_a.py 50.00% 2 Missing ⚠️
deepmd/dpmodel/descriptor/se_r.py 50.00% 2 Missing ⚠️
deepmd/dpmodel/model/dp_model.py 60.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3829      +/-   ##
==========================================
- Coverage   82.48%   81.14%   -1.34%     
==========================================
  Files         513      513              
  Lines       48993    49049      +56     
  Branches     2988     2986       -2     
==========================================
- Hits        40411    39803     -608     
- Misses       7671     8341     +670     
+ Partials      911      905       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.