Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pt): lower the atol for dpa2 test #3785

Merged
merged 1 commit into from
May 16, 2024

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented May 15, 2024

Opened an issue about this: #3786

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted tolerance values to improve the precision consistency for specific tests.

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

Walkthrough

The recent changes focus on adjusting the tolerance levels in the test_dpa2.py file. Specifically, the atol method in SomeClass now returns 1e-8 instead of 1e-10 for float64 precision, and the test_consistency function has its atol value changed from 1e-11 to 1e-8. These modifications aim to relax the tolerance criteria for numerical comparisons, potentially reducing false negatives in test results.

Changes

File Change Summary
.../descriptor/test_dpa2.py atol method in SomeClass now returns 1e-8 instead of 1e-10 for float64 precision.
.../descriptor/test_dpa2.py test_consistency function adjusted atol value from 1e-11 to 1e-8.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2bf0769 and da19ff8.
Files selected for processing (2)
  • source/tests/consistent/descriptor/test_dpa2.py (1 hunks)
  • source/tests/pt/model/test_dpa2.py (1 hunks)
Additional comments not posted (2)
source/tests/pt/model/test_dpa2.py (1)

89-89: Change in atol value for float64 precision is appropriate and aligns with the PR objective.

source/tests/consistent/descriptor/test_dpa2.py (1)

388-388: Change in atol value for float64 precision is appropriate and aligns with the PR objective.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@iProzd iProzd requested review from njzjz and wanghan-iapcm May 15, 2024 07:58
@iProzd iProzd changed the title chore(pt): lower the rtol and atol for dpa2 test chore(pt): lower the atol for dpa2 test May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (2bf0769) to head (da19ff8).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3785      +/-   ##
==========================================
- Coverage   82.49%   81.35%   -1.14%     
==========================================
  Files         515      515              
  Lines       48642    48620      -22     
  Branches     2980     2969      -11     
==========================================
- Hits        40126    39555     -571     
- Misses       7605     8105     +500     
- Partials      911      960      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue May 16, 2024
Merged via the queue into deepmodeling:devel with commit b2b126b May 16, 2024
59 checks passed
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
Opened an issue about this:
deepmodeling#3786

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted tolerance values to improve the precision consistency for
specific tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants