Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support serialize and deserialize for atomic model's compute output stat #3649

Merged
merged 4 commits into from
Apr 9, 2024
Merged

feat: support serialize and deserialize for atomic model's compute output stat #3649

merged 4 commits into from
Apr 9, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

  • implement serialize and deserialize for atomic model's compute output stat
  • intensive change to the linear atomic models' serialization. @anyangml please help checking the changes.

@wanghan-iapcm wanghan-iapcm requested review from njzjz and anyangml April 7, 2024 02:51
@github-actions github-actions bot added the Python label Apr 7, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 7, 2024
View reviewed changes
source/tests/pt/model/test_atomic_model_stat.py
to_torch_tensor(ii) for ii in [self.coord_ext, self.atype_ext, self.nlist]
]
# nf x nloc
at = self.atype_ext[:, :nloc]

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable at is not used.
@codecov Codecov
Copy link

codecov bot commented Apr 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.71429% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.83%. Comparing base (39d027e) to head (8da0c78).
Report is 2 commits behind head on devel.

Files Patch % Lines
deepmd/dpmodel/atomic_model/base_atomic_model.py 90.16% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3649      +/-   ##
==========================================
+ Coverage   81.80%   81.83%   +0.03%     
==========================================
  Files         503      503              
  Lines       46445    46533      +88     
  Branches     2952     2952              
==========================================
+ Hits        37993    38079      +86     
- Misses       7559     7561       +2     
  Partials      893      893

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz April 8, 2024 04:11
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Apr 9, 2024
Merged via the queue into deepmodeling:devel with commit fd2daeb Apr 9, 2024
48 checks passed
@wanghan-iapcm wanghan-iapcm deleted the atom-output-stat-3 branch April 9, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyangml anyangml anyangml approved these changes

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanghan-iapcm @njzjz @anyangml