Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multiprocess and buffer in multitask mode #3630

Closed
wants to merge 10 commits into from

Conversation

CaRoLZhangxy
Copy link
Collaborator

the trainer choose random model for each step. Prefetching for each model may be inefficient.

@github-actions github-actions bot added the Python label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.79%. Comparing base (15e4926) to head (8b7d43c).

Files Patch % Lines
deepmd/pt/train/training.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3630   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files         438      438           
  Lines       37693    37699    +6     
  Branches     1623     1623           
=======================================
+ Hits        29322    29327    +5     
- Misses       7507     7508    +1     
  Partials      864      864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm requested a review from iProzd April 1, 2024 10:01
Copy link
Collaborator

@iProzd iProzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there efficiency comparison before and after this modification in multitask training with numerous datasets?

@iProzd iProzd marked this pull request as draft April 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants