Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: use unified activation #3619

Merged
merged 3 commits into from
Mar 28, 2024
Merged

pt: use unified activation #3619

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7818956
pt: make gelu jit happy
iProzd Mar 28, 2024
ae47563
use unified activation
iProzd Mar 28, 2024
b199da2
Merge branch 'devel' into 0328_devel
iProzd Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion deepmd/pt/utils/utils.py
View file
Open in desktop
wanghan-iapcm marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@
if activation.lower() == "relu":
return F.relu
elif activation.lower() == "gelu" or activation.lower() == "gelu_tf":
return lambda x: F.gelu(x, approximate="tanh")

@torch.jit.script
def gelu_tanh(x):
return F.gelu(x, approximate="tanh")

Check warning on line 29 in deepmd/pt/utils/utils.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pt/utils/utils.py#L27-L29 

Added lines #L27 - L29 were not covered by tests

return gelu_tanh

Check warning on line 31 in deepmd/pt/utils/utils.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pt/utils/utils.py#L31 

Added line #L31 was not covered by tests
elif activation.lower() == "tanh":
return torch.tanh
elif activation.lower() == "relu6":
Expand Down