chore: remove incorrect memset TODOs #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deepmodeling#3556. Signed-off-by: Jinzhe Zeng <[email protected]>
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3600 +/- ##
==========================================
- Coverage 77.70% 77.69% -0.02%
==========================================
Files 432 433 +1
Lines 37356 37491 +135
Branches 1620 1620
==========================================
+ Hits 29028 29128 +100
- Misses 7467 7502 +35
Partials 861 861 ☔ View full report in Codecov by Sentry. |
denghuilu
approved these changes
Mar 26, 2024
Closed
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Apr 6, 2024
Fix deepmodeling#3556. Signed-off-by: Jinzhe Zeng <[email protected]> (cherry picked from commit 625e893)
Merged
njzjz
added a commit
that referenced
this pull request
Apr 6, 2024
Fix #3556. Signed-off-by: Jinzhe Zeng <[email protected]> (cherry picked from commit 625e893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3556.