-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: LinearModel Stat #3575
Fix: LinearModel Stat #3575
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3575 +/- ##
==========================================
+ Coverage 81.80% 81.82% +0.01%
==========================================
Files 503 503
Lines 46456 46426 -30
Branches 2952 2952
==========================================
- Hits 38004 37987 -17
+ Misses 7559 7546 -13
Partials 893 893 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Should be revised when the #3593 is solved. |
Signed-off-by: Anyang Peng <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test is required for the application of out_bias on the linearly combined model.
the other parts of the PR LGTM.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Refactor stat related methods in LinearAtomicModel.
This should resolve #3585 #3586 #3528