Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: LinearModel Stat #3575

Merged
merged 35 commits into from
Apr 8, 2024
Merged

Fix: LinearModel Stat #3575

merged 35 commits into from
Apr 8, 2024

Conversation

anyangml
Copy link
Collaborator

@anyangml anyangml commented Mar 21, 2024

Refactor stat related methods in LinearAtomicModel.
This should resolve #3585 #3586 #3528

@anyangml anyangml requested a review from njzjz March 21, 2024 08:19
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.82%. Comparing base (87d293a) to head (c8010bc).

Files Patch % Lines
deepmd/dpmodel/atomic_model/linear_atomic_model.py 33.33% 2 Missing ⚠️
...eepmd/pt/model/atomic_model/linear_atomic_model.py 90.90% 1 Missing ⚠️
...epmd/pt/model/atomic_model/pairtab_atomic_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3575      +/-   ##
==========================================
+ Coverage   81.80%   81.82%   +0.01%     
==========================================
  Files         503      503              
  Lines       46456    46426      -30     
  Branches     2952     2952              
==========================================
- Hits        38004    37987      -17     
+ Misses       7559     7546      -13     
  Partials      893      893              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anyangml anyangml marked this pull request as draft March 24, 2024 11:09
@anyangml anyangml changed the title Fix: LinearModel JIT export Fix: LinearModel Stat Mar 24, 2024
@anyangml anyangml marked this pull request as ready for review March 25, 2024 02:43
@wanghan-iapcm
Copy link
Collaborator

Should be revised when the #3593 is solved.

@anyangml anyangml marked this pull request as draft March 25, 2024 06:37
@anyangml anyangml requested review from njzjz and removed request for njzjz and iProzd April 7, 2024 08:02
@anyangml anyangml requested a review from wanghan-iapcm April 7, 2024 08:33
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test is required for the application of out_bias on the linearly combined model.
the other parts of the PR LGTM.

source/tests/pt/model/test_linear_atomic_model_stat.py Dismissed Show dismissed Hide dismissed
source/tests/pt/model/test_linear_atomic_model_stat.py Dismissed Show dismissed Hide dismissed
source/tests/pt/model/test_linear_atomic_model_stat.py Dismissed Show dismissed Hide dismissed
@anyangml anyangml marked this pull request as ready for review April 7, 2024 12:45
@anyangml anyangml added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@anyangml anyangml enabled auto-merge April 8, 2024 02:17
@anyangml anyangml added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@anyangml anyangml added this pull request to the merge queue Apr 8, 2024
Merged via the queue into deepmodeling:devel with commit ea98506 Apr 8, 2024
48 checks passed
@anyangml anyangml deleted the feat/linear-jit branch April 8, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants