-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pt: support multitask finetune #3480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3480 +/- ##
==========================================
+ Coverage 77.48% 77.59% +0.10%
==========================================
Files 432 432
Lines 37182 37314 +132
Branches 1620 1620
==========================================
+ Hits 28812 28955 +143
+ Misses 7502 7491 -11
Partials 868 868 ☔ View full report in Codecov by Sentry. |
njzjz
requested changes
Mar 17, 2024
wanghan-iapcm
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It seems that the change output bias should be place in atomic model (current bias can also be computed by the forward_atomic method)
- the implementation should be able to reused by other atomic models, including the zbl and linear models, thus it is either placed in base_atomic_model, or be designed as a common method called by models, just like the compute_output_stat.
anyangml
reviewed
Mar 18, 2024
5 tasks
njzjz
approved these changes
Mar 20, 2024
anyangml
approved these changes
Mar 20, 2024
wanghan-iapcm
requested changes
Mar 20, 2024
wanghan-iapcm
requested changes
Mar 21, 2024
This was
linked to
issues
Mar 21, 2024
wanghan-iapcm
approved these changes
Mar 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
change_energy_bias
intocompute_output_stats
and reformat it intochange_out_bias
ofmodel
level.Need fix in future PR:
type_map
. (If fixed,change_out_bias
func will not need the input paramsorigin_type_map
andfull_type_map
.) See also [BUG] Finetuned model has wrong type_map #3455.change_out_bias
support for other models.(e.g. Spin, ZBL, Polar, Dipole and Dos.)