Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: avoid D2H in se_e2_a #3424

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Mar 6, 2024

sec is used as a slice index, so it should not stored on the GPU, otherwise, D2H will happen to create the tensor with the shape.

Before:
image

After:
image

sec is used as slice index, so it should not stored on the GPU, otherwise D2H will happen to create the tensor with the shape.

Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz requested a review from wanghan-iapcm March 6, 2024 05:13
@github-actions github-actions bot added the Python label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.95%. Comparing base (278e6b8) to head (b810945).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3424   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         423      423           
  Lines       35883    35883           
  Branches     1620     1621    +1     
=======================================
  Hits        27612    27612           
  Misses       7403     7403           
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising...

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Mar 6, 2024
Merged via the queue into deepmodeling:devel with commit d3ca9d7 Mar 6, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants