Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt: support --init-frz-model #3350

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 28, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <[email protected]>
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.65%. Comparing base (004ebd6) to head (8a76ed6).

Files Patch % Lines
deepmd/pt/train/training.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3350   +/-   ##
=======================================
  Coverage   75.64%   75.65%           
=======================================
  Files         411      411           
  Lines       34569    34580   +11     
  Branches     1599     1603    +4     
=======================================
+ Hits        26151    26161   +10     
- Misses       7558     7559    +1     
  Partials      860      860           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a UT for it?

@njzjz njzjz requested a review from wanghan-iapcm February 28, 2024 03:35
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 28, 2024
@wanghan-iapcm wanghan-iapcm removed this pull request from the merge queue due to a manual request Feb 28, 2024
@njzjz njzjz added this pull request to the merge queue Feb 28, 2024
Merged via the queue into deepmodeling:devel with commit 897fcc5 Feb 28, 2024
49 checks passed
@njzjz njzjz deleted the pt-init-frz-model branch February 28, 2024 09:02
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants