Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add dipole consistency test #3321

Merged
merged 37 commits into from
Feb 23, 2024
Merged

Conversation

anyangml
Copy link
Collaborator

@anyangml anyangml commented Feb 22, 2024

This PR is to add cross framework consistency test on DipoleFittingNet.

Known Limitations:

  1. There are some mismatched keys in the serialized model, only common keys are tested.

@anyangml anyangml self-assigned this Feb 22, 2024
@anyangml anyangml marked this pull request as draft February 22, 2024 03:43
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.31%. Comparing base (6345207) to head (9ac39b8).
Report is 1 commits behind head on devel.

Files Patch % Lines
deepmd/tf/model/multi.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3321      +/-   ##
==========================================
+ Coverage   75.29%   75.31%   +0.01%     
==========================================
  Files         403      403              
  Lines       33910    33922      +12     
  Branches     1604     1604              
==========================================
+ Hits        25532    25547      +15     
+ Misses       7517     7514       -3     
  Partials      861      861              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
source/tests/consistent/fitting/test_dipole.py Dismissed Show dismissed Hide dismissed
deepmd/tf/fit/dipole.py Show resolved Hide resolved
source/tests/tf/test_data_modifier_shuffle.py Outdated Show resolved Hide resolved
deepmd/tf/fit/dipole.py Outdated Show resolved Hide resolved
source/tests/tf/test_data_modifier.py Outdated Show resolved Hide resolved
source/tests/tf/test_data_modifier_shuffle.py Outdated Show resolved Hide resolved
@anyangml anyangml requested a review from njzjz February 23, 2024 02:31
deepmd/tf/model/model.py Outdated Show resolved Hide resolved
@anyangml anyangml added the Test CUDA Trigger test CUDA workflow label Feb 23, 2024
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Feb 23, 2024
@anyangml anyangml requested a review from njzjz February 23, 2024 04:40
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 23, 2024
Merged via the queue into deepmodeling:devel with commit 260ef21 Feb 23, 2024
48 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants