pt: process frames in parallel for env mat stat #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves deepmodeling#3285 (comment) Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3293 +/- ##
==========================================
- Coverage 74.93% 74.92% -0.01%
==========================================
Files 391 391
Lines 33661 33650 -11
Branches 1604 1604
==========================================
- Hits 25224 25213 -11
Misses 7576 7576
Partials 861 861 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Feb 19, 2024
iProzd
approved these changes
Feb 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3285 (comment).
We don't even need to consider whether the data uses mixed type in this piece of code. The data can be reshaped to the atom level, and type masks can be used to get an environmental matrix with certain types. No frame-level things are involved here.