Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dp: pt: rearrange folder structure of atomic_model and model. #3268

Merged
merged 9 commits into from
Feb 15, 2024
Merged

dp: pt: rearrange folder structure of atomic_model and model. #3268

merged 9 commits into from
Feb 15, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm commented Feb 13, 2024 •
edited
Loading

  • create models dpmodel.atomic_model and pt.model.atomic_model.
  • place all the atomic model related codes into the new modules.
  • PairTabModel -> PairTabAtomicModel
  • ZBLModel -> DPZBLModel

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (25bf37a) 74.91% compared to head (3f51f0e) 74.81%.

Files Patch % Lines
deepmd/pt/model/model/dp_zbl_model.py 57.14% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3268      +/-   ##
==========================================
- Coverage   74.91%   74.81%   -0.11%     
==========================================
  Files         378      382       +4     
  Lines       33426    33419       -7     
  Branches     1600     1586      -14     
==========================================
- Hits        25041    25002      -39     
+ Misses       7514     7493      -21     
- Partials      871      924      +53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

njzjz
njzjz reviewed Feb 13, 2024
View reviewed changes
deepmd/dpmodel/atomic_model/__init__.py Show resolved Hide resolved
deepmd/dpmodel/model/__init__.py Outdated Show resolved Hide resolved
@anyangml
Copy link
Collaborator

LGTM

@wanghan-iapcm wanghan-iapcm merged commit aae4850 into deepmodeling:devel Feb 15, 2024
46 checks passed
@wanghan-iapcm wanghan-iapcm deleted the atomic-model-folder branch February 15, 2024 08:16
@wanghan-iapcm wanghan-iapcm restored the atomic-model-folder branch February 15, 2024 17:07
@wanghan-iapcm wanghan-iapcm deleted the atomic-model-folder branch February 15, 2024 17:10
@njzjz njzjz mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyangml anyangml anyangml approved these changes

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanghan-iapcm @anyangml @njzjz