Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add ZBL weighted DP model #3210

Merged
merged 111 commits into from
Feb 8, 2024

fix: jit

d1b6a9d
Select commit
Loading
Failed to load commit list.
Merged

Feat: add ZBL weighted DP model #3210

fix: jit
d1b6a9d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Feb 7, 2024 in 3s

3 new alerts including 1 error

New alerts in code changed by this pull request

  • 1 error
  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 161 in deepmd/pt/model/model/linear_atomic_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Wrong number of arguments in a call Error

Call to
method LinearAtomicModel._compute_weight
Loading
with too many arguments; should be no more than 0.

Check notice on line 189 in deepmd/dpmodel/model/linear_atomic_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Mismatch between signature and use of an overridden method Note

Overridden method signature does not match
call
Loading
, where it is passed too many arguments. Overriding method
method DPZBLLinearAtomicModel._compute_weight
Loading
matches the call.

Check notice on line 203 in deepmd/pt/model/model/linear_atomic_model.py

See this annotation in the file changed.

Code scanning / CodeQL

Mismatch between signature and use of an overridden method Note

Overridden method signature does not match
call
Loading
, where it is passed too many arguments. Overriding method
method DPZBLLinearAtomicModel._compute_weight
Loading
matches the call.