PT: keep the same checkpoint behavior as TF #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default save_ckpt to `model.ckpt` as the prefix. When saving checkpoints, `model.ckpt-100.pt` will be saved, and `model.ckpt.pt` will be symlinked to `model.ckpt-100.pt`. A `checkpoint` file will be saved to record `model.ckpt-100.pt`. This keeps the same behavior as the TF backend. Signed-off-by: Jinzhe Zeng <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try: | ||
| # remove old one | ||
| os.remove(new_ff) | ||
| except OSError: |
Check notice
Code scanning / CodeQL
Empty except Note
Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3191 +/- ##
==========================================
- Coverage 74.27% 74.27% -0.01%
==========================================
Files 343 343
Lines 31629 31634 +5
Branches 1592 1592
==========================================
+ Hits 23494 23497 +3
- Misses 7210 7212 +2
Partials 925 925 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <[email protected]>
wanghan-iapcm
approved these changes
Jan 28, 2024
Closed
|
hi @njzjz Can I know why you need different file extension The files and the file can we just use one of these ext for convenient when collect files in dpegen? |
|
No control flow is saved in the checkpoint file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default
save_ckpttomodel.ckptas the prefix. When saving checkpoints,model.ckpt-100.ptwill be saved, andmodel.ckpt.ptwill be symlinked tomodel.ckpt-100.pt. Acheckpointfile will be dedicated to recordmodel.ckpt-100.pt.This keeps the same behavior as the TF backend. One can do the below using the PT backend just like the TF backend:
dp --pt train input.json # one can cancel the training before it finishes dp --pt freeze