Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve "Multiplication result converted to larger type" #3159

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 20, 2024

Follow up #3149.

njzjz added 4 commits January 19, 2024 03:12
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz requested a review from wanghan-iapcm January 20, 2024 08:53
@njzjz njzjz changed the base branch from master to devel January 20, 2024 08:54
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (8c1b467) 76.05% compared to head (14d5e92) 76.06%.

Files Patch % Lines
source/api_c/include/deepmd.hpp 68.00% 7 Missing and 1 partial ⚠️
source/op/prod_virial_grad.cc 0.00% 2 Missing ⚠️
source/op/soft_min_virial_grad.cc 0.00% 2 Missing ⚠️
source/op/prod_force_grad.cc 0.00% 1 Missing ⚠️
source/op/prod_force_se_a_mask_grad.cc 0.00% 1 Missing ⚠️
source/op/prod_virial.cc 0.00% 1 Missing ⚠️
source/op/soft_min_force_grad.cc 0.00% 1 Missing ⚠️
source/op/soft_min_virial.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3159      +/-   ##
==========================================
+ Coverage   76.05%   76.06%   +0.01%     
==========================================
  Files         276      276              
  Lines       25586    25601      +15     
  Branches     1591     1591              
==========================================
+ Hits        19460    19474      +14     
- Misses       5202     5203       +1     
  Partials      924      924              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 1097062 into deepmodeling:devel Jan 20, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants