Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cross-platform AutoBatchSize #3143

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 13, 2024

See #3118 and dptech-corp/deepmd-pytorch#137. Subclass needs to implement is_gpu_available and is_oom_error.

See deepmodeling#3118 and dptech-corp/deepmd-pytorch#137.
Subclass needs to implement `is_gpu_available` and `is_oom_error`.

Signed-off-by: Jinzhe Zeng <[email protected]>
deepmd_utils/utils/batch_size.py Dismissed Show resolved Hide resolved
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2096b80) 76.23% compared to head (fe0d4ad) 76.24%.

Files Patch % Lines
deepmd_utils/utils/batch_size.py 95.71% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3143   +/-   ##
=======================================
  Coverage   76.23%   76.24%           
=======================================
  Files         267      268    +1     
  Lines       25424    25438   +14     
  Branches     1579     1579           
=======================================
+ Hits        19383    19396   +13     
- Misses       5116     5117    +1     
  Partials      925      925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz requested a review from wanghan-iapcm January 13, 2024 23:35
@wanghan-iapcm wanghan-iapcm merged commit 539e4ab into deepmodeling:devel Jan 14, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants